kubernetes/ingress-nginx

Feature Request: Allow disabling custom-http-errors per ingress

Open

#8,384 opened on Mar 23, 2022

View on GitHub
 (17 comments) (2 reactions) (2 assignees)Go (15,199 stars) (7,888 forks)batch import
good first issuehelp wantedkind/featureneeds-triagepriority/backlog

Description

When nginx.ingress.kubernetes.io/custom-http-errors is set to string off, overwrite the configmap value with an empty list instead of skipping it.

My current work-around is to use the 418 HTTP code (nginx.ingress.kubernetes.io/custom-http-errors: "418") because my apps aren't using it :wink:

Contributor guide

Tech stack
gokubernetes
Domain
backendinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingKubernetes basicsingress nginx controller architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the annotation parsing code for custom http errors, likely in internal/ingress/annotations/custom http errors. Modify the logic to treat the string 'off' as an empty list, overriding the configmap default. Check comments and linked PRs for prior discussion and ensure backward compatibility. Write tests for the new behavior.
Feature Request: Allow disabling custom-http-errors per ingress · kubernetes/ingress-nginx#8384 | Good First Issue