kubernetes/ingress-nginx

Support standard Forwarded header

Open

#10,263 opened on Aug 1, 2023

View on GitHub
 (15 comments) (9 reactions) (2 assignees)Go (15,199 stars) (7,888 forks)batch import
good first issuehelp wantedkind/featurepriority/backlogtriage/accepted

Description

As far as I can see the ingess controller currently just supports the "non-standard" X-Forwarded-* headers. It would be nice to support also the standard Forwarded header.

Use case

Keycloak has added support for the Forwarded header with version 21.0.0 and advices reverse-proxies to override this header.

Contributor guide

Tech stack
go
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingHTTP header knowledgeKubernetes ingress basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding support for the standard Forwarded HTTP header alongside the existing X Forwarded * headers. Key files to investigate are likely in the internal/ingress/controller or pkg/ingress directories, where header handling is implemented. Review the current X Forwarded * logic and adapt it to handle the Forwarded header per RFC 7239. The Keycloak release notes provide context on why this is needed. Check if there are any linked PRs or comments about implementation approach.