kubernetes-sigs/kubespray

Convert usages of nerdctl and crt to crictl

Open

#10,907 opened on Feb 8, 2024

View on GitHub
 (12 comments) (1 reaction) (1 assignee)HTML (4,419 forks)batch import
good first issuehelp wantedkind/feature

Repository metrics

Stars
 (10,380 stars)
PR merge metrics
 (Avg merge 25d) (26 merged PRs in 30d)

Description

What would you like to be added

We currently use (AFAICT):

  • ctr
  • crictl
  • nerdctl

If possible, we should use only one CRI frontend for manipulating images and containers.

Why is this needed

  1. Avoiding complexity in the playbooks and roles (usage of "command variables" such as crictl_image_pull_command, etc)
  2. Reducing the number of tasks, download and config steps.

Not sure what the pros and cons of each are. ctr looks more minimal, maybe that's enough for what we need to do in Kubespray ? wdyt @yankay @mzaian @floryut @MrFreezeex ?

EDIT: We'll use crictl as it's required by kubeadm, and compatible with all container runtime. -> this is no longer the case.

Usage sites can be converted by small batch, then once the conversion is done we'll be able to remove the download of nerdctl and ctr.

Blockers: mainly the usage of save/load, as this isn't in CRI.

Contributor guide

Research direction
Identify all playbooks and roles that use nerdctl or ctr commands; replace them with equivalent crictl commands; handle the save/load blocker by using crictl save/load if available otherwise use alternative like ctr for load; update variable names and remove unnecessary downloads.
Tech stack
pythonshell
Domain
devopsinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
crictlKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50