kubernetes-sigs/cluster-api

BeforeClusterUpgrade is not called with cp unavailable

Open

#8,942 opened on Jun 30, 2023

View on GitHub
 (14 comments) (1 reaction) (0 assignees)Go (1,532 forks)auto 404
help wantedkind/bugpriority/backlogtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

What steps did you take and what happened?

Using ClusterClass we found an unexpected behavior when we try to upgrade the cluster and intercept the BeforeClusterUpgrade hook using RuntimeSDK. If a ControlPlane isn't in an healthy state the hook doesn't get propagated to the runtime extension, I think this is logically wrong and in contrast with the documentation.

What did you expect to happen?

To receive the BeforeClusterUpgrade request even if the ControlPlanes are unhealthy and manage the problem in the phase of upgrading.

Cluster API version

1.4.2+

Kubernetes version

1.27.2

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

Contributor guide

Research direction
Investigate the upgrade controller logic in Cluster API that decides whether to invoke lifecycle hooks. Look for condition checks on control plane health before calling BeforeClusterUpgrade. The issue might be in the upgrade controller's reconcile loop where it checks control plane status before proceeding with hooks.
Tech stack
go
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetesCluster API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30