kubernetes-sigs/cluster-api

Latest staging images being published with the wrong pre-release tag

Open

#8,404 opened on Mar 28, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Go (1,532 forks)auto 404
help wantedkind/bugpriority/important-longtermtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

What steps did you take and what happened?

Staging images are published after each merge at CAPI with main tags and a hashed tag. The images can be seen at https://console.cloud.google.com/gcr/images/k8s-staging-cluster-api/global/cluster-api-controller

Currently the hashed tag has the form v20230328-v1.4.0-beta.2-131-g022c70b2b containing beta.2 instead of rc.1 which is the latest pre-release tag.

I believe this image is created from the post-submit job at https://github.com/kubernetes/test-infra/blob/e249292bf64b2f35526ca4c762cedd28b47f2ee0/config/jobs/image-pushing/k8s-staging-cluster-api.yaml#LL3C31-L3C31

What did you expect to happen?

Tag should contain containing rc.1 instead of beta2 which is the latest pre-release tag.

Cluster API version

rc.1

Kubernetes version

No response

Anything else you would like to add?

I think this is likely down to a regex or git tag command going wrong somwhere - but the versions I've tried so far appear to have worked.

Label(s) to be applied

/kind bug One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

Contributor guide

Research direction
Investigate the post submit job that builds and pushes staging images. Trace how the tag is computed, likely from `git describe` or similar. Check the configuration in https://github.com/kubernetes/test infra/blob/e249292bf64b2f35526ca4c762cedd28b47f2ee0/config/jobs/image pushing/k8s staging cluster api.yaml and any related scripts. The issue is that the tag contains 'beta.2' instead of 'rc.1', so look for where the latest pre release tag is determined.
Tech stack
go
Domain
devopsinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCI/CD
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65