kubernetes-sigs/cluster-api

uninitialized taint should always be dropped

Open

#8,258 opened on Mar 9, 2023

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Go (1,532 forks)auto 404
area/machinepoolhelp wantedkind/featurepriority/important-longtermtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

Detailed Description

https://github.com/kubernetes-sigs/cluster-api/pull/7993 introduced the node.cluster.x-k8s.io/uninitialized:NoSchedule taint. This taint is applied by default to the nodes when CAPBK is used as the bootstrap provider. CAPI drops this taint from the nodes after the nodes are initialized (labels are synced).

This issue is to audit and ensure that the node is dropped by CAPI when using any of the Machine/MachinePool solutions.

  • Machines
  • MachinePoll
  • MachinePool Machines

[A clear and concise description of what you want to happen.]

Anything else you would like to add:

More context on the taint: The taint was introduced to solve the delay problem when syncing label to nodes to avoid unnecessarily scheduling workloads on wrong nodes. Part of proposal: Label Sync Between Machines and underlying Kubernetes Nodes

/kind feature

Contributor guide

Research direction
Locate the code that drops the uninitialized taint for Machines and MachinePool (already implemented), and replicate the logic for MachinePool Machines. Check the controllers that handle taint removal and ensure MachinePool Machines are covered.
Tech stack
go
Domain
infrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetesCluster API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60