kubernetes-sigs/cluster-api

ClusterClass rebase should check variable compatibility

Closed

#8,154 opened on Feb 22, 2023

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)Go (1,532 forks)auto 404
area/clusterclasshelp wantedkind/featurepriority/important-longtermtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

PR #8153 removes the variable compatibility checks for Clusters using a ClusterClass when that class is being updated in place. This change is a consequence of external variables.

During ClusterClass rebase - moving a Cluster from one ClusterClass to another - similar variable checks could be done allowing users to safely update from one set of variables to another while changing ClusterClass. Currently validation of those variables is not done during ClusterClass rebase.

This validation should be added to give rebase webhook based validation of variable changes.

/area topology /kind feature

Contributor guide

Research direction
Review the variable compatibility checks in internal/topology/check/compatibility.go, especially the function at line 200. Understand the difference between ClusterClass update and rebase. Design a validation for rebase that checks variable compatibility.
Tech stack
go
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55