kubernetes-sigs/cluster-api

Drop internal/log package

Open

#7,029 opened on Aug 5, 2022

View on GitHub
 (13 comments) (2 reactions) (0 assignees)Go (1,532 forks)auto 404
area/clusterclasshelp wantedkind/cleanuppriority/important-longtermtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

internal/log has been introduced while developing the topology controller in order to easy our path towards structured logging.

Now that structured logging is well integrated in klog and we have clear logging guidelines I think we can drop this package (eventually we can add by simply adding a couple of utility func to the topology controller, TBD)

/area topology /kind cleanup

cc @ykakarap @sbueringer @killianmuldoon opinions?

Contributor guide

Research direction
Remove the internal/log package and update all imports to use klog directly. Ensure no references remain and verify tests pass.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70