kubernetes-sigs/cluster-api

Enable usetesting in golangci.yml

Open

#12,179 opened on May 9, 2025

View on GitHub
 (5 comments) (1 reaction) (1 assignee)Go (1,532 forks)auto 404
help wantedkind/cleanuppriority/backlogtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

usetesting linter is automatically enabled when Go 1.24 is used.

This linter diagnose the calls that can be replaced by functions defined in testing package. e.g. os.Setenv -> testing.Setenv.

It is what we're going to do after https://github.com/kubernetes-sigs/cluster-api/pull/12128 will be merged since the diff is very large.

The issue aims to enable usetesting linter and the fix all diagnostics to pass all.

/help

Contributor guide

Research direction
Enable the usetesting linter in .golangci.yml, then run it to identify all diagnostics. For each diagnostic, replace the standard library call with the corresponding testing package function (e.g., os.Setenv > testing.Setenv). Ensure all tests pass after changes.
Tech stack
go
Domain
backendtesting
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gogolangci lint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60