kubernetes-sigs/cluster-api

Drop two ways contract for machine's failure domain

Open

#11,232 opened on Sep 27, 2024

View on GitHub
 (3 comments) (1 reaction) (1 assignee)Go (1,532 forks)auto 404
help wantedkind/cleanuppriority/important-soontriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

Since 0.3.0 we are supporting a two ways contract for machine's failure domain, which is really confusing.

Most specifically, we are supporting a deprecated reverse process where InfraMachine was authoritative WRT to failure domain placement (this was implemented for allowing a transparent transition from when there was no failure domain support in Cluster API)

This issue is about creating awareness on the fact that we are going to drop the reverse process entirely with v1beta2.

I also already added an heads up warning to the infra machine contract page in https://github.com/kubernetes-sigs/cluster-api/pull/11223

Rif https://github.com/kubernetes-sigs/cluster-api/blame/274d7e21e1ac2eb89b3f5986f6a09ff9db4eeacc/internal/controllers/machine/machine_controller_phases.go#L324-L333

/kind cleanup /priority important-soon /triage accepted /help

Contributor guide

Research direction
Understand the current two way contract for failure domain in the machine controller and remove the reverse process. Trace the code in internal/controllers/machine/machine controller phases.go and related files.
Tech stack
go
Domain
backendinfrastructure
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25