kubernetes-sigs/cluster-api

Deleting retries history during KCP remediation

Open

#10,911 opened on Jul 19, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (1,532 forks)auto 404
area/control-planehelp wantedkind/bugpriority/important-longtermtriage/accepted

Repository metrics

Stars
 (4,267 stars)
PR merge metrics
 (PR metrics pending)

Description

What steps did you take and what happened?

At a random moment, during the KCP remediation process, a machine is created without the history of previous retries. The remedation-in-progress annotation hangs on the KCP resource and is deleted after some time.

It turns out that the retry history is not saved.

What did you expect to happen?

Retry history is saved

Cluster API version

1.7

Kubernetes version

1.27.14

Anything else you would like to add?

I think that this happens when the resource is patched, and at the next stage of reconciliation the control plane is listed without these annotations.

Label(s) to be applied

/kind bug /area control-plane

Contributor guide

Research direction
Investigate how retry annotations are stored and patched during KCP remediation. Look at the KCP controller code for remediation logic, especially where annotations are set and patched, to understand why retry history might be dropped.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetesCluster API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70