kubernetes-sigs/cluster-api-provider-vsphere

Move e2e test setup from Bash to go

Open

#2,044 opened on Jul 20, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Go (320 forks)auto 404
help wantedkind/feature

Repository metrics

Stars
 (417 stars)
PR merge metrics
 (PR metrics pending)

Description

/kind feature

Describe the solution you'd like

hack/e2e.sh includes a bunch of Node IPAM setup code that would better be served being added to a ginkgo SynchronizedBeforeSuite setup for better debuggability.

CAPA has good examples of using this method to pass data to test suites in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/test/e2e/suites/conformance/conformance_suite_test.go#L45C7-L49 and https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/test/e2e/shared/suite.go#L209-L269

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

Contributor guide

Research direction
Examine the CAPA examples for SynchronizedBeforeSuite, then refactor the Bash setup code in hack/e2e.sh into Go within the test suite's SynchronizedBeforeSuite.
Tech stack
go
Domain
backendtesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGinkgoe2e testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60