kubernetes-sigs/aws-load-balancer-controller

support new domain prefixes for our annotations

Open

#3,377 opened on Sep 6, 2023

View on GitHubContributor guide
 (3 comments) (2 reactions) (0 assignees)Go (1,644 forks)auto 404
good first issuekind/feature

Repository metrics

Stars
 (4,317 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? We need to support new domain prefixes for our annotations. Per discussions in sig-cloud-provider: https://kubernetes.slack.com/archives/C718BPBQ8/p1693843844752649`, the service.beta.kubernetes.io style of annotations is deprecated and we should use a AWS-specific prefix.

Describe the solution you'd like we can support both the old service.beta.kubernetes.io prefix and a new aws-specific one. and announce deprecation of the service.beta.kubernetes.io prefix.

Describe alternatives you've considered N/A

Contributor guide

Research direction
Locate all usages of the `service.beta.kubernetes.io` annotation prefix in the controller code and its tests. Understand the annotation parsing logic, then add support for a new AWS specific prefix while keeping backward compatibility and deprecation messaging.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75