kubernetes-sigs/aws-load-balancer-controller

Not able to enable Automatic Application Layer Mitigation in AWS Shield Advanced.

Open

#2,777 opened on Aug 25, 2022

View on GitHubContributor guide
 (11 comments) (14 reactions) (1 assignee)Go (1,644 forks)auto 404
elbgood first issuekind/feature

Repository metrics

Stars
 (4,317 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem?

After enabling the AWS Shield Advanced protection for an ALB via alb.ingress.kubernetes.io/shield-advanced-protection: 'true', the protection gets created but the Automatic application layer DDoS mitigation is Disabled by default. I see no flag or annotation to enable it.

https://aws.amazon.com/blogs/aws/aws-shield-advanced-update-automatic-application-layer-ddos-mitigation/

Describe the solution you'd like We should be able to enable and disable the Automatic application layer DDoS mitigation for the created protection.

Contributor guide

Research direction
Investigate the annotation handling for 'alb.ingress.kubernetes.io/shield advanced protection' in the controller. Find where the Shield Advanced protection is created, and check if the AWS SDK for Shield supports enabling automatic application layer mitigation. Look at the controller's existing patterns for adding similar feature flags, and explore existing tests to understand expected behavior.
Tech stack
go
Domain
backendcloudsecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGoKubernetesAWS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70