kubernetes-client/python

leaderelection do not stop leading properly

Open

#2,075 opened on Jun 12, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (3,323 forks)batch import
help wantedkind/bug

Repository metrics

Stars
 (6,225 stars)
PR merge metrics
 (Avg merge 10d 3h) (2 merged PRs in 30d)

Description

What happened (please include outputs or screenshots): After onstarted_leading function throw exception and finish, the process still leading.

What you expected to happen: The process stop leading immediatly.

How to reproduce it (as minimally and precisely as possible): Just follow the leaderelection/example.py.

Anything else we need to know?: Go client use ctx.Done() to find out the OnStartedLeading finish, and then release lock: https://github.com/kubernetes/client-go/blob/1309f64d6648411b4a36a2f7fa84dd8df31884b6/tools/leaderelection/leaderelection.go#L265-L291

Environment:

  • Kubernetes version (kubectl version): v1.20.15
  • OS (e.g., MacOS 10.13.6): 10.15.7
  • Python version (python --version): 3.8.10
  • Python client version (pip list | grep kubernetes): 21.7.0

Contributor guide

Research direction
Examine how the leader election library triggers OnStartedLeading and how to detect when it finishes; consider using a future or callback similar to Go's context cancellation.
Tech stack
python
Domain
backenddistributed systems
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPythonKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60