Support running without code generation from strings

Open
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript, node.js
Domain
tooling

Research direction

No files or tests are named in the issue. Start by tracing ordered-binary's current code-generation paths and the Node.js --disallow-code-generation-from-strings behavior; done means the package falls back when string code generation is blocked while retaining its existing generated path.

Written by the indexing model from the issue text.

Description

Node.js supports running with the --disallow-code-generation-from-strings CLI flag, which blocks features such as eval and new Function('...').

Packages like ordered-binary benefit from the performance gain of code generation, but I would like to see an automatic fallback in the event the current environment does not allow for code generation from strings.

Would you be open to such a change? I'm using this as a consumer of lmdb if that makes any difference.

Dominant language
JavaScript
Stars
12
Forks
6
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from kriszyp/ordered-binary

All issues in kriszyp/ordered-binary

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.