kristijanhusak/laravel-form-builder

Embedded child form models being converted to arrays

Open

#184 opened on Nov 18, 2015

View on GitHub
 (6 comments) (0 reactions) (0 assignees)PHP (305 forks)github user discovery
help wanted

Repository metrics

Stars
 (1,715 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am trying to add a child form that uses a related model.

$this
            ->add('name', 'text')
            ->add('directories', 'form', [
                'class'       => 'DirectoriesForm',
                'formOptions' => [
                    'model' => $this->model ? $this->model->directories : null,
                ],
            ])

In \Kris\LaravelFormBuilder\Form::setupNamedModel it is converting the child model to an array, so I can't call any methods on it. Why is this? It prevents me from calling any model methods in the child form. As far as I know, I'm not even using a named form, unless this happens automatically for child forms. If I get rid of the dotName stuff and just set

            $this->model = [
                $this->getName() => $this->getModel()
            ];

it seems to work fine. Am I doing something wrong here? Thanks.

Contributor guide

Research direction
Inspect the setupNamedModel method in Form.php line 894 to understand why it converts the child model to an array, and trace the usage of dotName to see if it is necessary for child forms.
Tech stack
phplaravel
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PHPLaravel
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65