kontent-ai/delivery-sdk-php

Research&Implement: Use PHP-DI for Dependency Injection

Open

#42 opened on Jan 5, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)PHP (13 forks)auto 404
groomedhacktoberfesthelp wantedrefactoringup-for-grabs

Repository metrics

Stars
 (46 stars)
PR merge metrics
 (PR metrics pending)

Description

Dependencies like typeMapper, propertyMapper, valueConverter, *Factory could be injected using DI. If we implemented DI, we could also have a default container and get rid of method such as getModelBinder.

The goal of this task is to:

  • research whether using a DI framework such as PHP-DI for loading the dependencies in a library such as delivery-sdk-php is a good practice and how it could be implemented properly.
  • either close this issue or implement the DI, based on the findings

Resources:

Contributor guide

Research direction
Research PHP DI documentation to understand how to set up a container and inject dependencies like typeMapper, propertyMapper, etc. Then identify all current dependency instantiations in the codebase and plan to refactor them using the container. Finally, discuss the pros and cons in the issue comments.
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPDependency Injection concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40