koajs/koa

request.ip via x-forwarded-for should strip out ports

Open

#827 opened on Oct 4, 2016

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (3,215 forks)batch import
help wanted

Repository metrics

Stars
 (35,713 stars)
PR merge metrics
 (Avg merge 9h 19m) (2 merged PRs in 30d)

Description

on azure (yes, i know), ports are also being sent as well as the ip in x-forwarded-for:

'x-forwarded-for': '23.243.1.1:38242'

request.ip should not return the port section. aye or nay?

Contributor guide

Research direction
Find where koa parses x forwarded for header and strip the port if present.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HTTP headersGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80