koajs/koa

request.ip via x-forwarded-for should strip out ports

Open

#827 opened on Oct 4, 2016

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (35,713 stars) (3,215 forks)batch import
help wanted

Description

on azure (yes, i know), ports are also being sent as well as the ip in x-forwarded-for:

'x-forwarded-for': '23.243.1.1:38242'

request.ip should not return the port section. aye or nay?

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptunderstanding of HTTP headers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Focus on Koa's request object, specifically the 'ip' getter in lib/request.js. The x forwarded for header may include a port (e.g., '23.243.1.1:38242'). The task is to strip the port from the IP address. Look at the existing code for parsing the header and ensure only the IP is returned.