cmd: invoke reads --file data from disk twice (redundant I/O)

Open
#3,846 1 comment 0 reactions 1 assignee View on GitHub

@Elvand-Lie is already working on this.

Since Jun 2, 2026.

Assessment

This issue has not been assessed yet.

Description

kind/cleanup

Description

When --file is passed to func invoke, the file contents are read from disk twice:

  1. In newInvokeConfig() (line 280-286) — reads file into cfg.Data
  2. In runInvoke() (line 201-207) — reads the same file again into m.Data

The second read is redundant because m.Data is already initialized from cfg.Data at line 195, which already contains the file contents from the first read. The second read at line 206 just overwrites m.Data with identical content.

Impact

  • Wasted I/O (file read twice for every invocation with --file)
  • TOCTOU consistency risk: if the file changes between the two reads, the behavior would be unpredictable

Proposed Fix

Remove the second os.ReadFile block in runInvoke() (lines 200-207). The file is already read into cfg.Data during config creation.

/kind cleanup

Dominant language
Go
Stars
365
Forks
223
Avg merge
2d 3h
Merged PRs (30d)
25

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from knative/func

All issues in knative/func

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.