kimmobrunfeldt/spawn-default-shell

cmd.exe returns incorrect exit code

Open

#4 opened on Sep 30, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

Test case "&& operator should work" is failing because cmd.exe doesn't return the exit code as expected.

This is what happens with cmd.exe /c:

It works in a cmd.exe session:

I don't know yet how to fix this issue. If anyone has ideas, please help.

Contributor guide

Research direction
Investigate how cmd.exe returns exit codes when using the /c flag, and trace the spawn process in Node.js to see how the exit code is captured.
Tech stack
javascriptnodejs
Domain
clibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsWindows environment
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70