Incorrect location header returned by Trigger invoice group run endpoint

Open Beginner friendly
#1,929 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
java
Domain
api

Research direction

Start at jaxrs/src/main/java/org/killbill/billing/jaxrs/resources/InvoiceResource.java around line 398 and review the Trigger invoice group run endpoint alongside the Retrieve invoice group endpoint. Verify how the location header is constructed and how accountId is required as a query parameter. Done means the location header includes both the invoice group id and accountId so client libraries can retrieve the invoice group from it.

Written by the indexing model from the issue text.

Description

bug JAXRS

The Trigger invoice group run endpoint returns the group id in the location header. However, the client libraries (Java, PHP, etc.) are unable to obtain the invoice group using this location header as the Retrieve invoice group endpoint also requires the accountId to be specified as a query parameter. Thus, the code needs to be fixed here to also return the accountId in the location header.

Dominant language
Java
Stars
5.8k
Forks
959
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from killbill/killbill

All issues in killbill/killbill

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.