keystonejs/keystone-classic

Front Page Icon Missing in Mobile Navigation in Admin UI

Open

#4603 opened on Mar 24, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
4.x candidatebughelp wanted

Description

At the right hand side of Admin UI Navigation Bar, there are 2 buttons - one for going to main page (Globe Icon) and one for sign out. This is ok with Primary View. However, when viewed in Mobile, the main page icon will be missing.

Searched inside github and found the octicon only present in Navigation/Primary view, but not mentioned in Navigation/Mobile view.

https://github.com/keystonejs/keystone/search?utf8=%E2%9C%93&q=octicon-globe&type=

Kindly see if this is by design but currently seems I have no way to switch from Admin UI to main page in mobile devices. Thanks.

Software Version
Keystone 4.0.0-beta.5
Node v8.10.0

Contributor guide

Tech stack
javascriptnodejs
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with Keystone's Admin UI navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue reports that the globe icon for returning to the main page is missing in the mobile navigation bar. The fix likely involves adding the octicon globe component to the mobile navigation view, similar to how it's included in the primary view. Investigate the Admin UI's navigation components in the keystone classic repository, specifically files under `admin/ui/` or `public/` related to navigation. The search for 'octicon globe' shows it's present in primary navigation but absent in mobile, so locate the mobile navigation partial and add the icon.