keystonejs/keystone-classic

TextType - Over-length value validates when both max and min specified

Open

#4536 opened on Dec 28, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
4.x candidatebughelp wanted

Description

Expected behavior

When both max and min are specified in a field definition, over length strings should be refused.

Actual/Current behavior

Over length string accepted

Steps to reproduce the actual/current behavior

Define a field as per below: name: { type: Types.Text, required: true, min: 3, max: 5 }, Enter a string longer than 5 characters Submit

Environment

Keystone master (0ca9eb18c00fb051c579105ae7d283f98b182d8d) Node v9.2.0

Notes

Issue seems to be caused by a922b38a12bad632ef6f5d992ea91b363bb78d4f. If min length validation passes, all other validation results are discarded.

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the validation logic in the TextType implementation, specifically around the handling of min and max constraints. The issue was introduced in commit a922b38, where after min validation passes, other validations are skipped. Look for the validation function that checks length and ensure that both min and max are evaluated independently. Propose a fix to validate both conditions.