keystonejs/keystone-classic

Adding `track` or `defaultSort` to any List breaks admin UI

Open

#4512 opened on Nov 14, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Any ideas whatsoever would be great.

Expected behavior

I should be able to instantiate a new List with track or defaultSort set without an issue.

Actual/Current behavior

But for some reason, I get the following error on the /keystone/signin page:

signin.js:978 Uncaught TypeError: $export is not a function
    at Object.76../_descriptors (signin.js:978)
    at s (signin.js:1)
    at signin.js:1
    at Object.15.../../modules/_core (signin.js:83)
    at s (signin.js:1)
    at signin.js:1
    at Object.4.core-js/library/fn/object/define-property (signin.js:19)
    at s (signin.js:1)
    at signin.js:1
    at Object.48../_an-object (signin.js:610)

Steps to reproduce the actual/current behavior

Just add one of the aforementioned options to a List, old or new.

Environment

Software Version
Keystone 4.0.0-beta.7
Node 8.9.1

Babel config:

{
  "presets": [
    ["env", {
      "targets": {
        "node": "current"
      }
    }],
    ["stage-0"]
  ],
  "plugins": [
    "transform-runtime",
    "import-glob"
  ]
}

Contributor guide

Tech stack
javascriptnodejs
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptKeystone classic basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the error '$export is not a function' from core js. This likely indicates a module bundling issue triggered by adding 'track' or 'defaultSort' to a List. Examine the Keystone classic source code for List class initialization and how these options are processed. Also check the admin UI build configuration (babel and webpack) to see if the options cause a discrepancy in module imports. The issue is from 2017 and has few comments, so no clear resolution yet. Reproduction may require setting up a Keystone project with those options and debugging the client side bundle.