keystonejs/keystone-classic

Prompt to save changes to a post before navigating away

Open

#4491 opened on Nov 1, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
feature requesthelp wanted

Description

Expected behavior

We should track when changes are made to the form since the last save, and if the user is navigating away from the edit page while there are unsaved changes, prompt them to save or to confirm their navigation action.

Actual/Current behavior

Current behavior is that there is no check for unsaved changes. If the user accidentally navigates away from the edit page, then these changes are lost.

Steps to reproduce the actual/current behavior

  1. Select a post from the admin page to edit
  2. On the edit screen, make some changes to the post
  3. Navigate away from the edit screen without clicking the save button

At this point, if you view the selected post, the unsaved changes will be lost.

Environment

Software Version
Keystone master branch of the repo (npm linked)
Node 6.11.2

Contributor guide

Tech stack
javascriptreactnodejs
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScript event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the admin UI code for editing posts, likely in a React component. Look for how navigation is handled (e.g., React Router) and implement a `beforeunload` event or a custom prompt. Check if there are existing hooks for form dirtiness (like `useState` with `isDirty`). Review similar features in the repo or linked resources. The maintainer has not provided additional guidance, so the contributor should start by reading the current form submission code path.