keystonejs/keystone-classic

babel settings in root directory are used for keystone module

Open

#4488 opened on Oct 30, 2017

View on GitHub
 (4 comments) (1 reaction) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Expected behavior

Admin.js should not fail with errors

Actual/Current behavior

When using the transform-runtime plugin for babel admin.js crashes with

TypeError: $export is not a function

as babel-polyfill is reading .babelrc or package.json.

Steps to reproduce the actual/current behavior

create a babelrc file with plugin: transform-runtime

Environment

Software Version
Keystone 4.0.0-beta.7
Node 6.10

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Babel configurationFamiliarity with Node.js module resolutionUnderstanding of Keystone admin.js build processAbility to test changes locally
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue occurs when a user's .babelrc file with transform runtime plugin conflicts with Keystone's admin.js build. Investigate how Keystone loads Babel configuration; likely the admin module inherits root .babelrc settings. Check the Keystone repository for its own Babel config (e.g., in `admin/` or `keystone/` packages). Consider isolating the admin module's Babel config using `env` or a custom `.babelrc` that overrides root settings. Reproduce the bug by creating a test project with transform runtime and running admin.js. Look at the keystone classic source code for babel configuration to identify the exact files involved.