keystonejs/keystone-classic

Bind Ctrl + s event to save functionality on 'Edit Post' screen

Open

#4,480 opened on Oct 24, 2017

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
enhancementhelp wanted

Description

Expected behavior

When the user is editing a post of theirs, they should be able to press ctrl + s to save the content

Actual/Current behavior

When the user is editing a post of theirs, ctrl + s simply performs the default browser behavior and prompts to save the html version of the page.

Steps to reproduce the actual/current behavior

  • Select a post from the admin page and choose to edit the post
  • press the ctrl and then the 's' keys

Environment

Software Version
Keystone master branch of the repo (npm linked)
Node 6.11.2

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Look at the 'Edit Post' view in the admin UI (likely in `/admin` or `/views`). The save function is probably triggered by a button click. Add a keydown listener on the document or the edit form that prevents default and calls the save function when Ctrl+S is pressed. Check existing keybindings in the codebase to follow conventions.