keystonejs/keystone-classic

TextArray field type causes client JS errors

Open

#4412 opened on Aug 8, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Expected behavior

  1. No JS error when item is selected from Select field.
  2. Additionally dependsOn working when set in TextArray field.

Actual/Current behavior

  1. Error thrown: Uncaught TypeError: nextProps.value.join is not a function whenever item is selected from a Select field.
  2. TextArray field does not appear when dependency met.

Steps to reproduce the actual/current behavior

TestList.add({
	selection: { type: Types.Select, initial: true, required: true, options: 'a,b,c' },
	items: { type: Types.TextArray, initial: true, dependsOn: { selection: 'b' } }
});

Environment

Software Version
Keystone 4.0.0-beta.5
Node 8.2.1

Contributor guide

Tech stack
javascriptreactnodejs
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Keystone field typesFamiliarity with React admin UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the TextArray field component and the Select field component in the Keystone admin UI. The error 'nextProps.value.join is not a function' suggests that nextProps.value is not an array. Check how the value is passed from the Select field to the TextArray field. Also, examine the dependsOn logic to ensure the TextArray field appears when dependency is met. Relevant files are likely in the fields directory, such as 'fields/types/TextArray.js' and 'fields/types/Select.js'.