keystonejs/keystone-classic

TextArray field type causes client JS errors

Open

#4,412 opened on Aug 8, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior

  1. No JS error when item is selected from Select field.
  2. Additionally dependsOn working when set in TextArray field.

Actual/Current behavior

  1. Error thrown: Uncaught TypeError: nextProps.value.join is not a function whenever item is selected from a Select field.
  2. TextArray field does not appear when dependency met.

Steps to reproduce the actual/current behavior

TestList.add({
	selection: { type: Types.Select, initial: true, required: true, options: 'a,b,c' },
	items: { type: Types.TextArray, initial: true, dependsOn: { selection: 'b' } }
});

Environment

Software Version
Keystone 4.0.0-beta.5
Node 8.2.1

Contributor guide

Research direction
Investigate the client side field rendering for TextArray in Keystone, specifically the value handling that causes the 'join is not a function' error, and ensure dependsOn triggers correctly.
Tech stack
javascriptnodejs
Domain
frontendbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60