keystonejs/keystone-classic

Drag and drop ordering doesn't work well when filter is applied

Open

#4384 opened on Jul 12, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Expected behavior

When filtering a list, drag and drop re-ordering should place list items in the correct order (within the context of the filtered items).

Actual/Current behavior

When an item is dragged into a new position in the list, it's sortOrder is being set to it's position in the current list (which may not be the correct value when some items have been filtered out).

Steps to reproduce the actual/current behavior

For example, if I'm filtering my list in such a way that shows items with sortOrders of 1,5, 6 and 7, If I drag the fourth item (with sort order of 7) above the third item (with sort order of 6) it's sort order is then updated to '3' (it's position in the current filtered list), meaning that the items now have sort orders on 1, 5, 3 and 7 and have in fact have been put into an incorrect order.

I can see where list.model.reorderItems is being called but I'm having trouble finding where this is defined in order to take a look at this myself.

Environment

Software Version
Keystone 4.0.0-beta.5
Node 6.9.4

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of KeystoneJS list modelUnderstanding of drag and drop ordering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the definition and behavior of the reorderItems function in the List model. Check how filter state affects the calculation of sortOrder. The issue indicates that the current implementation uses the position in the filtered list rather than the actual global order. Look for related code in the Keystone source, possibly in the admin UI or server side model logic. Review any existing tests or related PRs for context.