keystonejs/keystone-classic

Markdown field ignores `hiddenButtons` of `toolbarOptions` property

Open

#4378 opened on Jul 2, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Expected behavior

toolbarOptions.hiddenButtons String - Comma separated list of buttons to hide.

{ type: Types.Markdown, toolbarOptions: { hiddenButtons: 'H1,H6,Code' } }

This should make H1, H2 and Code buttons to hide from the toolbar according to: http://keystonejs.com/docs/database/#fieldtypes-markdown

Actual/Current behavior

Buttons H1, H2 and Code are still in the toolbar, toolbarOptions.hiddenButtons does nothing.

Environment

Software Version
Keystone 4.0.0
Node 6.10.3, 7.10.0, 8.1.1

Contributor guide

Tech stack
javascriptnodejs
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptFamiliarity with Keystone
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Markdown field type's frontend component, likely located in the `fields/types/markdown` directory. Look for where `toolbarOptions` is used and how `hiddenButtons` is processed. The fix should ensure `hiddenButtons` is applied when initializing the toolbar.