keystonejs/keystone-classic

Markdown field ignores `hiddenButtons` of `toolbarOptions` property

Open

#4,378 opened on Jul 2, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior

toolbarOptions.hiddenButtons String - Comma separated list of buttons to hide.

{ type: Types.Markdown, toolbarOptions: { hiddenButtons: 'H1,H6,Code' } }

This should make H1, H2 and Code buttons to hide from the toolbar according to: http://keystonejs.com/docs/database/#fieldtypes-markdown

Actual/Current behavior

Buttons H1, H2 and Code are still in the toolbar, toolbarOptions.hiddenButtons does nothing.

Environment

Software Version
Keystone 4.0.0
Node 6.10.3, 7.10.0, 8.1.1

Contributor guide

Research direction
Investigate the Markdown field toolbar initialization in keystone classic to locate where `hiddenButtons` should be processed. Check the field type definition and the client side code that renders the toolbar to find why the setting is ignored.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptKeystoneJS basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75