keystonejs/keystone-classic

4.0.0: Twig cache still set to true in developpment

Open

#4,268 opened on May 7, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When passing env to developpment, twig cache isn't set to false, I have to set it manually in node_modules/twig/twig.js. In fact whatever the setting of env and cache view, the twig cache is always set to true.

Software Version
Keystone 4.0.0
Node v7.3.0

Contributor guide

Research direction
Investigate the code where Twig is initialized in Keystone 4.0.0. The issue is that the cache setting is not being disabled when NODE ENV is 'development'. Trace the configuration handling to find where the twig cache option is set and ensure it respects the environment variable. Check if there is a default that overrides the environment based setting.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75