keystonejs/keystone-classic

4.0.0: Twig cache still set to true in developpment

Open

#4,268 opened on May 7, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

When passing env to developpment, twig cache isn't set to false, I have to set it manually in node_modules/twig/twig.js. In fact whatever the setting of env and cache view, the twig cache is always set to true.

Software Version
Keystone 4.0.0
Node v7.3.0

Contributor guide

Tech stack
nodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Node.js knowledgeunderstanding of environment variables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue states that Twig cache remains true in development mode regardless of env setting. Investigate how Keystone 4.0.0 reads environment configuration, particularly the `env` parameter and any Twig cache options. Look at the relevant files like `keystone.js` or the module loading of twig. Check if there's a missing condition to set `cache: false` when `env` is set to 'development'. Examine the current release's source code for how Twig is initialized. The fix likely involves ensuring the cache option is properly passed based on the environment.