keystonejs/keystone-classic

Sort by relationship always sorts by _id of related field even though name is rendered in admin UI

Open

#4,251 opened on May 1, 2017

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behavior

When sorting by a relationship field, the sort should be alphabetical by the string that is actually rendered in the admin UI.

Actual/Current behavior

Currently the support appears to be alphabetical by the ObjectId.toString() value of the related document's _id property.

Steps to reproduce the actual/current behavior

  1. Create two Lists and include a String name property on each.
  2. Create relationship between one List and the other (many: false) and set defaultSort on the relationship owner to the property name of the relationship.
  3. Create a number of documents for the related List with various name values.
  4. Access the admin ui for that List and observe the sort.

Environment

Software Version
Keystone 4.0.0-beta.5
Node 7.6.0

Contributor guide

Research direction
Investigate the sorting logic for relationship fields in Keystone's GraphQL or database queries to determine why it defaults to sorting by id instead of the display field.
Tech stack
javascriptnodejsmongodb
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsKeystone
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60