keystonejs/keystone-classic

Strange behavior in creating page where there is a TextArray field

Open

#4158 opened on Mar 30, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Expected behavior

Actual/Current behavior

Steps to reproduce the actual/current behavior

  1. create a model like this:
const Test = new keystone.List('Test');

Test.add({
	tags: { type: Types.TextArray, required: false, initial: true },
	remark: { type: String, initial: true },
});

2.visit admin ui and open create page(ie. [http://localhost:3000/keystone/tests]), click 'Create Test' 3.Then click 'Cancel' button but the popup window does not close.And all other fields seems to be disabled until you add some tags. 4.If some tags are added first, then the page works normally.

Environment

Software Version
Keystone 4.0.0-beta.5
Node 6.10.1

Contributor guide

Tech stack
javascript
Domain
backendfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of KeystoneJSFamiliarity with admin UI codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the TextArray field implementation in KeystoneJS classic admin UI. The bug is triggered when creating a new item with a TextArray field that is not required but set as initial field. The Cancel button does not close the popup, and other fields become disabled until tags are added. Look at the admin UI code for handling initial fields and form validation, particularly the relationship between required and initial fields. The issue file likely involves the TextArray field type in the keystone/fields directory and the admin UI's create item logic.