keystonejs/keystone-classic

Keystone Beta 4.0.0-beta.5 - required being ignored for type: Types.File and image preview not working

Open

#4,064 opened on Mar 3, 2017

View on GitHub
 (10 comments) (6 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The admin is ignoring that a file is required and also it's image preview:

image: {
	type: Types.File,
	storage: storage,
	filename: function (item, file) {
		return item.id + '.' + file.extension
	},
	format: function (item, file) {
		return '<img src="' + file.href + '" style = "max-width: 120px">'
	},
	allowedTypes: ['jpg', 'png', 'jpg', 'gif'],
	required: true,
	initial: true,
},

image

Contributor guide

Research direction
Investigate the Keystone admin UI code that handles file type fields. Focus on how the `required` attribute is implemented for `Types.File`. Also check the image preview rendering logic. Look for discrepancies between the field configuration and the admin behavior.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptKeystone CMS basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70