keystonejs/keystone-classic

`auth: false` or left out in `keystone.init` stops admin UI rendering

Open

#4046 opened on Mar 1, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Steps to reproduce the behavior

Start a keystone project with auth: false, load /keystone

Expected behavior

We can access the admin UI, even if we are not logged in

Actual behavior

Admin UI fails to load with 500 error Cannot read property 'id' of undefined, which comes from keystone/admin/server/routes/index.js:39

Contributor guide

Tech stack
javascriptnodejs
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of Keystone.js admin UIFamiliarity with Express routes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate 'admin/server/routes/index.js' at line 39 where the error occurs. The code assumes an 'id' property on an object that is undefined when auth is disabled. Check if the middleware that sets the current user is skipped when auth is false. The fix likely involves adding a null check or conditionally skipping user dependent logic. Review comments in the issue for any proposed solutions or maintainer guidance.