keystonejs/keystone-classic

mime type error on file upload with FS adapter (when only specifying path)

Open

#4017 opened on Feb 19, 2017

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Steps to reproduce the behavior

  1. have a model with a field of type File and the file system adapter
  2. try to upload a file by calling model._.yourFileField.upload({path: specifiy your path})

Expected behavior

the file appears in the directory specified in the file system adapter

Actual behavior

an error occurs: mime is not a function

it happens because in lib/storage/index.js line 120 the mime type is tried to be evaluated when it wasn't specified in the file parameter, but the call has to be mime.lookup(file.path)

Contributor guide

Tech stack
javascriptnodejsexpress
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Node.jsKeystoneJS file uploads
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug is in lib/storage/index.js at line 120 where `mime(file.path)` is used instead of `mime.lookup(file.path)`. The fix is straightforward: replace `mime(file.path)` with `mime.lookup(file.path)`. No linked PRs or recent comments suggest any blockers. The assignee may have a solution, but the issue is open. Ensure the fix aligns with the existing codebase style and testing practices.