keystonejs/keystone-classic

Missing e2e test coverage

Open

#3968 opened on Feb 5, 2017

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (14,656 stars) (2,288 forks)batch import
help wantedtesting

Description

This issue to it track all missing e2e tests. Currently, our test suite is missing quite a lot, and issues which should be caught are slipping through. Currently, most fields undergo a standard set of tests, where the field is simply filled with some test value. However, we should also check validation and other config options are working as intended.

Since we don't always have the time to add tests, we should keep this list up to date, so that when we do have time to work on it, we know exactly what needs doing.

As new issues are logged, they should all be evaluated as to whether they should have been caught by e2e, and if so they should be added to this list.

Some of the items in this list may require changes on the keystone-nightwatch-e2e issue. If so, there is a corresponding issue (https://github.com/keystonejs/keystone-nightwatch-e2e/issues/36) to add them to, and issues here should be marked with (depends on KNE) in the list.

Missing functionality:

  • Html fields with wysiwyg: true (depends on KNE)

Fields which are not tested:

  • File fields are not tested
  • Cloudinary fields are not tested

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
KeystoneJS field typese2e testing basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the existing e2e test setup in the keystone classic repository, likely using nightwatch. Refer to the linked keystone nightwatch e2e issue #36 for dependencies. Start by implementing tests for file and Cloudinary fields, ensuring validation and config options are tested. Check the test directory and existing e2e test files for patterns.