keystonejs/keystone-classic

UrlField: missing refactor

Open

#3,884 opened on Jan 12, 2017

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
help wantedquestion

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi :) I'm not sure if this is an issue but while I was doing some work with keystone I saw this line:

UrlField.js

Is wrapField() correct or should this be renderUI().

Contributor guide

Research direction
Check the UrlField.js file to confirm if `wrapField()` should be `renderUI()` based on the pattern used in other field types.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85