keystonejs/keystone-classic

IE11 doesn't support responseType: json

Open

#3734 opened on Nov 23, 2016

View on GitHub
 (10 comments) (2 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Steps to reproduce the behavior

  1. Using IE (even IE11), access the admin panel. Any website is fine, even the demo website. You might need fix #3733 to do that.
  2. Select a model to list all its entries

Expected behavior

See the entries

Actual behavior

The entries aren't shown and the loader stays where it is. The error occurs in the method showBlankState(). The reason is that the value of this.props.items is a string and not an array. Therefore, IE isn't able to access the property results and this code this.props.items.results.length generates an error.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptfamiliarity with KeystoneJS admin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the `showBlankState()` method in `admin/client/App/screens/List/index.js` (line 415). The issue is that `this.props.items` is a string instead of an array in IE11 due to `responseType: json` not being supported. Consider adding a polyfill for `responseType` or checking the type and parsing manually. Look for existing workarounds in the KeystoneJS codebase or use a fetch polyfill.