keystonejs/keystone-classic

[4.0.0-beta.3] Validation of type Name

Open

#3722 opened on Nov 20, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Steps to reproduce the behavior

  1. Create list with required field with type Name
  2. Get model and create new item keystone.List(listName).model().save()

Expected behavior

Get validation error

Actual behavior

Item successfully saved

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the validation logic for the 'Name' field type in KeystoneJS. Look at the source files for field types (e.g., fields/types/Name) and check how 'required' validation is enforced. The issue might be that the required check is bypassed for 'Name' fields. Compare with other field types like 'Text' to see how they handle required validation. Look for any test files that cover required field validation for Name.