keystonejs/keystone-classic

/admin/public/js/packages.js is checked in to git

Open

#3246 opened on Aug 1, 2016

View on GitHub
 (7 comments) (2 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
enhancementhelp wanted

Description

There's an 840k file at /admin/public/js/packages.js containing compiled code. This file shouldn't be checked in to git, but generated by a tool.

Contributor guide

Tech stack
javascriptnodejs
Domain
build systemdeveloper experience
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
git.gitignore
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
First, determine how packages.js is generated (likely from a build script in package.json or a gulp/grunt task). Then, update .gitignore to exclude /admin/public/js/packages.js. Finally, remove the file from git tracking using git rm cached. Check if there are any other generated files to exclude as well.