keystonejs/keystone-classic

Field type 'Datetime' - format customization missing

Open

#3,160 opened on Jul 14, 2016

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (2,288 forks)batch import
4.x candidatebughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There is no working way to specify the format of Datetime. Also the placeholder is hardcoded in DatetimeField.js

<FormInput name={this.props.paths.time} value={this.state.timeValue} placeholder="HH:MM:SS am/pm" onChange={this.timeChanged} autoComplete="off" />

Contributor guide

Research direction
Inspect the DatetimeField.js component to understand how the placeholder is hardcoded. Add a new prop for format customization and update the component to use it. Ensure the format is passed correctly to the underlying form input.
Tech stack
javascriptreact
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60