keystonejs/keystone-classic

Keystone admin JS not minified

Open

#2825 opened on May 12, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
help wanted

Description

http://localhost:3000/keystone/js/index.js is not minified.

$ NODE_ENV=production node server.js 
$ curl http://localhost:3000/keystone/js/index.js | wc -c
 1312064 (1.3M)
$ curl http://localhost:3000/keystone/js/index.js | uglify -cm | wc
  472863 (473K)

Contributor guide

Tech stack
javascriptnodejsexpress
Domain
performance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look into the build configuration file (likely gulpfile.js or Gruntfile.js) to add a minification step for the JavaScript bundle. Consider using uglify js or similar. There are no linked PRs or comments indicating prior work. The admin JS is served at /keystone/js/index.js, so the fix involves adding a minification plugin in the production build pipeline.