keystonejs/keystone-classic

Make less files not publicly available

Open

#1,639 opened on Sep 2, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,288 forks)batch import
bughelp wanted

Repository metrics

Stars
 (14,656 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Every file under /public/styles/ is available through http when keystone is running.

Since *.less files could be considered as a part of the source code, could we move them to another location, e.g. /templates/styles/ to protect them from being available publicly?

It may be a good idea to keep /public/ folder only for files that are required during runtime, and keep source files elsewhere.

Contributor guide

Research direction
Investigate how Keystone.js serves static files and configure it to exclude less files from public access.
Tech stack
javascript
Domain
security
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Keystone.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60