keystonejs/keystone-classic

Make less files not publicly available

Open

#1639 opened on Sep 2, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (14,656 stars) (2,288 forks)batch import
bughelp wanted

Description

Every file under /public/styles/ is available through http when keystone is running.

Since *.less files could be considered as a part of the source code, could we move them to another location, e.g. /templates/styles/ to protect them from being available publicly?

It may be a good idea to keep /public/ folder only for files that are required during runtime, and keep source files elsewhere.

Contributor guide

Tech stack
javascriptnodejscss
Domain
securitybackend
Issue type
security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Keystone file structureLess CSSNode.js static serving
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current file structure under /public/styles/ and /templates/ to understand how Keystone serves static assets. Identify all references to style files in the application (e.g., in templates, layout files, or server configuration) that would need updating after the move. Check if there are any existing mechanisms to prevent public access to certain file types, and consider if a more general solution (like a .htaccess or middleware) is preferred. Review any comments on the issue for maintainer guidance on the desired approach.