keycloak/keycloak

SAML broker: Assertions without a Conditions element are accepted unconditionally

Open

#48,878 opened on May 11, 2026

View on GitHub
 (1 comment) (1 reaction) (1 assignee)Java (8,346 forks)batch import
area/identity-brokeringhelp wantedkind/weaknesspriority/normalstatus/auto-bumpteam/core-iam

Repository metrics

Stars
 (34,398 stars)
PR merge metrics
 (Avg merge 6d 19h) (384 merged PRs in 30d)

Description

Area

SAML

Describe the bug

Admins can not enforce NotBefore and NotOnOrAfter for SAML Identity Providers

Acknowledgement

Thank you to Jason from the TossLab of the University of Toronto who reported this. This was triaged to be a hardening.

Version

26.6.x

Expected behavior

For new providers, the setting should be enabled be default to enforce NotBefore and NotOnOrAfter for assertions.

Actual behavior

Keycloak does not enforce it.

How to Reproduce?

See the code and reproducer provided by Jason

This issue was originally tracked in the private repository. Migrated by @ahus1.

Contributor guide

Research direction
Locate the SAML assertion validation code in Keycloak's SAML broker. Identify where Conditions element is parsed and enforce NotBefore/NotOnOrAfter checks for new identity providers by default.
Tech stack
java
Domain
authenticationsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50