kevva/is-exe

What about a text file starts with 'MZ'?

Open

#2 opened on Nov 19, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (0 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

I think you'd better add more check on the buffer, includes but not limited to:

  • The buffer length should be at least 0x80 bytes, which is the minimum DOS stub of a modern PE file.
  • Use DataView.getUint32(0x3C) to get a point say P, and use DataView.getUint32(P) to get the PE signature, and check whether it is 0x50450000.

Contributor guide

Research direction
Examine the current detection logic in the codebase and add the proposed checks for DOS stub length and PE signature.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75