kestra-io/kestra

Warn in the UI (e.g. when clicking on "Save") if a scheduled flow has inputs that have no defaults + no inputs set on the trigger

Open

#2881 opened on Jan 16, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Java (26,854 stars) (2,579 forks)batch import
area/frontendgood first issue

Description

Feature description

Use case

The following flow:

id: missing_default
namespace: qa

inputs:
  - name: user
    type: STRING

tasks:
  - id: hello
    type: io.kestra.core.tasks.log.Log
    message: hey there {{ inputs.user }}! 👋

triggers:
  - id: every_minute
    type: io.kestra.core.models.triggers.types.Schedule
    cron: "*/1 * * * *"

Will fail every minute because the user forgot to enter a default value: Missing variable: 'inputs' on 'hey there {{ inputs.user }}!

Question

Can we provide a warning/error message in the UI when an input is used somewhere within a scheduled flow even though it has no defaults + no inputs set on the schedule?

if not possible/easy to do, please close the issue

this is only to help users discover such issues as early as possible

Contributor guide

Tech stack
typescriptvue
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Vue.jsUnderstanding of kestra's scheduling system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the UI save logic for flows, likely in the FlowEditor component. Look for validation that runs on save, and determine where to add a check for scheduled triggers with inputs lacking defaults. Check the Schedule trigger implementation to understand how inputs are resolved. The issue has 4 comments; one may contain hints about relevant files.