keras-team/keras-preprocessing

Adding tests for Exception error messages

Open

#31 opened on Aug 2, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,028 stars) (453 forks)batch import
good first issuehelp wanted

Description

If any contributor is feeling up for it, it would be good to add unit tests that check that appropriate error messages are getting raised in various situations not yet covered. It seems that a few error messages were previously incorrectly formatted, because we don't have unit tests for some of these exceptions.

We have some such unit tests already, which look like this:

with pytest.raises(ValueError) as e_info:
      generator.flow((images, x_misc_err), np.arange(dsize), batch_size=3)
      assert 'All of the arrays in' in str(e_info.value)

Contributor guide

Tech stack
pythonnumpy
Domain
backenddata
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
pytest basicsPython testingkeras preprocessing code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine existing test files in the repository for examples of error message testing. Identify uncovered exception paths in the codebase and write pytest assertions to verify the error messages. Ensure tests follow the pattern shown in the issue: using pytest.raises and checking str(e info.value). Focus on ValueError and other exceptions raised in the preprocessing functions.