kennethormandy/normalize-opentype.css

Collapsing inline-blocks with font-size: 0

Open

#6 opened on Jun 26, 2014

View on GitHub
 (6 comments) (0 reactions) (0 assignees)HTML (797 stars) (29 forks)batch import
bughelp wantedquestion

Description

I also tried dropping it into twitter.com via dev tools, and it broke the profile page in Chrome. We use inline blocks for the layout, and font-size:0 to collapse whitespace between elements. Looks like the font-feature-settings prevents that from happening.

https://github.com/necolas/normalize.css/issues/343#issuecomment-47190238

Contributor guide

Tech stack
csshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
css knowledgeunderstanding of font feature settings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes that setting font feature settings prevents collapsing whitespace via font size:0. To fix, investigate the CSS specification and test if there is a workaround or if the rule should exclude certain properties. Look at the normalize.css issue linked and check the normalize opentype.css code for where font feature settings is applied. Consider adding a comment or condition to avoid breaking inline block layouts.